From 9b1b7615e2e511a7ba2f3b5cbef723e6bda8a243 Mon Sep 17 00:00:00 2001 From: seb Date: Wed, 16 Sep 2026 17:04:08 +0200 Subject: [PATCH] refactor(manifestLines): standardize on tax and remove taxrate alias --- README.md | 3 +-- src/store/manifestLines.js | 8 ++------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 2599aef..3f493aa 100644 --- a/README.md +++ b/README.md @@ -333,8 +333,7 @@ type DeliveryLine = { amount: number, net: number, rebate: number, - tax: number, // manifestarticle.taxrate (also exposed as taxrate) - taxrate: number, + tax: number, // manifestarticle.taxrate comment: string | null, } diff --git a/src/store/manifestLines.js b/src/store/manifestLines.js index 36eb88a..c29c9e0 100644 --- a/src/store/manifestLines.js +++ b/src/store/manifestLines.js @@ -28,10 +28,7 @@ export function normalizeLines(lines) { const net = entry?.net; const rebate = entry?.rebate === undefined || entry?.rebate === null ? 0 : entry.rebate; - const tax = - entry?.taxrate !== undefined && entry?.taxrate !== null - ? entry.taxrate - : entry?.tax; + const tax = entry?.tax; const comment = entry?.comment === undefined || entry?.comment === null ? null @@ -77,7 +74,7 @@ export function parseDate(value) { * @returns {object} The shaped line. */ export function shapeLine(row) { - const tax = row.taxrate !== undefined ? Number(row.taxrate) : Number(row.tax); + const tax = Number(row.tax); return { id: row.id, sku: row.sku ?? null, @@ -87,7 +84,6 @@ export function shapeLine(row) { net: row.net, rebate: row.rebate, tax, - taxrate: tax, comment: row.comment ?? null, }; }