u

scripts/test-shipment.js

@@ -150,29 +150,47 @@ async function run() {
     }
     assert.ok(exhaustedErrorThrown, 'Expected exhausted error to be thrown');
 
-    // 5. Add packages to Shipment 1 with tracking codes
+    // 5. Add packages to Shipment 1 with tracking codes and carrier
+    const carrier = await store.carrier.create(googleAuthId, {
+      name: 'DHL',
+      hasPackages: true,
+      isReverse: false,
+    });
+    assert.equal(carrier.name, 'DHL');
+    assert.equal(carrier.hasPackages, true);
+    assert.equal(carrier.isReverse, false);
+
     const pkg1 = await store.shipping.create(googleAuthId, {
       manifestId: shipment1.id,
+      carrierId: carrier.id,
       type: 'parcel',
       state: 'draft',
       trackingCode: 'TRACK-111',
-      carrier: 'DHL',
     });
     assert.equal(pkg1.trackingCode, 'TRACK-111');
+    assert.equal(pkg1.carrierId, carrier.id);
     assert.equal(pkg1.carrier, 'DHL');
     assert.equal(pkg1.state, 'draft');
     console.log('PASS: Package 1 created for Shipment 1:', pkg1.number, pkg1.trackingCode);
 
     const pkg2 = await store.shipping.create(googleAuthId, {
       manifestId: shipment1.id,
+      carrierId: carrier.id,
       type: 'parcel',
       state: 'draft',
       trackingCode: 'TRACK-222',
-      carrier: 'DHL',
     });
     assert.equal(pkg2.trackingCode, 'TRACK-222');
+    assert.equal(pkg2.carrierId, carrier.id);
     console.log('PASS: Package 2 created for Shipment 1:', pkg2.number, pkg2.trackingCode);
 
+    // Verify carrier in use prevents deletion
+    await assert.rejects(
+      () => store.carrier.delete(googleAuthId, carrier.id),
+      { message: 'Carrier in use' },
+    );
+    console.log('PASS: Carrier delete rejected while referenced in shipping');
+
     // Check listByOrderId
     const orderShipments = await store.shipment.listByOrderId(googleAuthId, order.id);
     assert.equal(orderShipments.length, 2);