seb/node-similarity-search-native
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enhance search index handling by returning an empty array for no results instead of throwing an error. Improve memory management in free_words function by checking for NULL before freeing. Update search_index to properly return NULL when no results are found.

Browse Source
This commit is contained in:
seb
2025-06-27 03:15:45 +02:00
parent 21f527ba46
commit 8474c77163
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
similarity_search.c
View File

@@ -48,7 +48,9 @@ int split_into_words(const char *s,
// Free memory allocated for words // Free memory allocated for words
void free_words(char *storage) { /* simplified */ void free_words(char *storage) { /* simplified */
if (storage) { /* check for NULL */
free(storage); /* single free, if any */ free(storage); /* single free, if any */
}
} }
// Calculate Levenshtein distance between two strings // Calculate Levenshtein distance between two strings
@@ -105,7 +107,7 @@ float word_similarity(const char *word1, const char *word2) {
// Calculate similarity between query and target string // Calculate similarity between query and target string
float calculate_similarity(const char *query, const char *target, float cutoff) { float calculate_similarity(const char *query, const char *target, float cutoff) {
// Split strings into words // Split strings into words
char *query_buf, *target_buf; char *query_buf = NULL, *target_buf = NULL;
char *query_words[MAX_WORDS], *target_words[MAX_WORDS]; char *query_words[MAX_WORDS], *target_words[MAX_WORDS];
int query_word_count = split_into_words(query, query_words, &query_buf); int query_word_count = split_into_words(query, query_words, &query_buf);
@@ -304,6 +306,12 @@ SearchResult* search_index(SearchIndex* index, const char* query, float cutoff,
} }
} }
// If no results found, return NULL properly
if (*num_results == 0) {
free(temp_results);
return NULL;
}
// Sort results by similarity // Sort results by similarity
qsort(temp_results, *num_results, sizeof(SearchResult), compare_results); qsort(temp_results, *num_results, sizeof(SearchResult), compare_results);

6
similarity_search_addon.cc
View File

@@ -129,9 +129,9 @@ Napi::Value SearchIndexWrapper::Search(const Napi::CallbackInfo& info) {
int num_results = 0; int num_results = 0;
SearchResult* results = search_index(this->index_, query.c_str(), cutoff, &num_results); SearchResult* results = search_index(this->index_, query.c_str(), cutoff, &num_results);
if (!results) { // If no results found, return empty array instead of throwing error
Napi::Error::New(env, "Search failed").ThrowAsJavaScriptException(); if (!results || num_results == 0) {
return env.Null(); return Napi::Array::New(env, 0);
} }
Napi::Array result_array = Napi::Array::New(env, num_results); Napi::Array result_array = Napi::Array::New(env, num_results);