refactor: Default log file path to script directory in install, config, and capture scripts.

This commit is contained in:
sebseb7
2025-12-18 14:23:38 +01:00
parent 36f79547d6
commit 374601f2fa
3 changed files with 7 additions and 12 deletions

View File

@@ -33,7 +33,7 @@ VIDEO_DEVICE="${VIDEO_DEVICE:-/dev/video0}"
RESOLUTION="${RESOLUTION:-1920x1080}" RESOLUTION="${RESOLUTION:-1920x1080}"
SKIP_FRAMES="${SKIP_FRAMES:-5}" SKIP_FRAMES="${SKIP_FRAMES:-5}"
TEMP_DIR="${TEMP_DIR:-/tmp}" TEMP_DIR="${TEMP_DIR:-/tmp}"
LOG_FILE="${LOG_FILE:-/var/log/picupper.log}" LOG_FILE="${LOG_FILE:-${SCRIPT_DIR}/picupper.log}"
TIMEOUT="${TIMEOUT:-30}" TIMEOUT="${TIMEOUT:-30}"
MAX_RETRIES="${MAX_RETRIES:-3}" MAX_RETRIES="${MAX_RETRIES:-3}"
RETRY_DELAY="${RETRY_DELAY:-5}" RETRY_DELAY="${RETRY_DELAY:-5}"

View File

@@ -7,7 +7,7 @@ set -euo pipefail
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
CAPTURE_SCRIPT="${SCRIPT_DIR}/capture-upload.sh" CAPTURE_SCRIPT="${SCRIPT_DIR}/capture-upload.sh"
CONFIG_FILE="${SCRIPT_DIR}/picupper.conf" CONFIG_FILE="${SCRIPT_DIR}/picupper.conf"
LOG_FILE="/var/log/picupper.log" LOG_FILE="${SCRIPT_DIR}/picupper.log"
echo "=== PicUpper Installer ===" echo "=== PicUpper Installer ==="
echo "" echo ""
@@ -56,14 +56,9 @@ chmod +x "$CAPTURE_SCRIPT"
chmod +x "${SCRIPT_DIR}/uninstall.sh" 2>/dev/null || true chmod +x "${SCRIPT_DIR}/uninstall.sh" 2>/dev/null || true
echo "✓ Scripts are executable" echo "✓ Scripts are executable"
# Create log file if needed # Touch log file to ensure it exists
if [[ ! -f "$LOG_FILE" ]]; then touch "$LOG_FILE" 2>/dev/null || true
sudo touch "$LOG_FILE" echo "✓ Log file: $LOG_FILE"
sudo chown "$USER:$USER" "$LOG_FILE"
echo "✓ Log file created: $LOG_FILE"
else
echo "✓ Log file exists: $LOG_FILE"
fi
# Set up cron job # Set up cron job
CRON_JOB="* * * * * $CAPTURE_SCRIPT >> $LOG_FILE 2>&1" CRON_JOB="* * * * * $CAPTURE_SCRIPT >> $LOG_FILE 2>&1"

View File

@@ -34,8 +34,8 @@ SKIP_FRAMES=5
# Temporary file location # Temporary file location
TEMP_DIR="/tmp" TEMP_DIR="/tmp"
# Log file location # Log file location (default: same directory as script)
LOG_FILE="/var/log/picupper.log" LOG_FILE=""
# Connection timeout in seconds # Connection timeout in seconds
TIMEOUT=30 TIMEOUT=30